Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 7 months ago

Results Summary Component without JSON

ShadowCoder040•70
@ShadowCoder040
A solution to the Results summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud that after a lot of frustration with the summary side, I am glad I didn't give up and can present a decent looking result + a decent looking result on mobile screen.

What challenges did you encounter, and how did you overcome them?

After trying to use semantic html tags for the summary side of the container (table and list) I had to give up and use separate divs instead because I just couldn't align the icons with the text.

What specific areas of your project would you like help with?

I don't know any Javascript as of now, so integrating the json data was too difficult for me. If someone could explain to me how it works I am happy to try it out. After doing a couple of challenges here on Frontend Mentor I want to move on to learning Javascript soon as well.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Dylan Heslop•2,460
    @dylan-dot-c
    Posted 7 months ago

    Hello there! This is a great challenge and I think you did well in the design aspect, but you could improve in other areas.

    • Semantic HTML: You could be more semantic with your html code by using main(for the main content) and section(for the 2 sections) you could also make the card an article if you want
    <body>
       <main>// fix the landmark error(cant see it, but it sometime is there)
           <article>container
               <section></section> //container result
               <section></section> // container summary
           </article>
        </main>
    </body>
    

    -CSS: You have 100vh on the height of the body, while that aint too bad its a bit restrictive as for some screen sizes arent that long and it will cause the content to be cropped in some way, also it will look weird on a rotated mobile screen.

    Good Job and take care

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub