Tryt4n• 940
@Tryt4n
Posted
In overall it's well written. BEM class architecture is good but folder structure could be better.
src folder isn't asset
In assets folder should be images, fonts, etc.
For colors you could make new colors file
In base folder you could split the base file into several different files. For example base, font-face, typography, helpers
If you would have helpers file you could put there visually-hidden class and use it in your h1 instead of card__title--hidden because it's not modifier. You are just visually hiding this element from the user not modifying it.
Marked as helpful
1
@3eze3
Posted
@Tryt4n Hey thanks for taking the time, and your advice, I will take it into account for my next projects. I really found them useful.
0
