Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results summary page

Ohsandβ€’ 70

@ohsand

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My css for the summary elements with the icons isn't very pretty, I had to give each an individual id to apply correct colors, any tips on a more efficient way to get the same result would me much appreciated!

Community feedback

Abdul Khalid πŸš€β€’ 72,160

@0xabdulkhalid

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage
  • So fix it by replacing the <div id="main"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.
  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

  • This solution has generated accessibility error report due to skipping heading levels which warn us as "Heading levels should only increase by one"
  • We want to avoid skipping heading levels, make sure to start with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that our document has a clear and consistent hierarchy. Read more πŸ“š
  • Because skipping heading levels is a poor practice from the perspective of information design, whether we are talking about web pages, books, journal articles, or about anything else. You can not only confuse screen readers but all readers when you don't follow a consistent, logical pattern with your heading structure.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

Ohsandβ€’ 70

@ohsand

Posted

@0xAbdulKhalid Thank you very much for the feedback, I really appreciate it! I always think of h1 as the largest and h6 as the smallest but I'll follow your advice from now on!

0
IRVINE MESAβ€’ 1,855

@DrMESAZIM

Posted

hi Ohsand

this was great work from you. Now I want to work on the hover effect when i hover through the button referred here

<button id="continueButton">Continue</button>

We can reduce the opacity on hover to make the solution match the expectations of the design . Also I want to improve on mobile view to reduce the with of "main" class so that it does not take up the whole page

If you find my suggestions difficult to implement . You can join us for our weekly live streams where we assists other developers by providing helpful reviews and feedback with live Frontend mentor code edits and reviews on this link. Your solution will also be reviewed and edited by myself live link here >> https://youtube.com/live/L6WTd7HRTMM?feature=share

Marked as helpful

0

Ohsandβ€’ 70

@ohsand

Posted

@DrMESAZIM I completely forgot to add a hover effect on the button to be honest! For the main class I followed the images provided where on mobileview there is no margin and it takes up the full width but if I were to add another media query for tablets and mobile landscapes I would have added a bit of margin I think!

0
Dana Yatsutaβ€’ 160

@danaYatsuta

Posted

I don't think there's anything wrong with assigning each category an id and selecting them that way, but a way to do this without ids is via :nth-of-type pseudo-class. In your case, .summaryItem:nth-of-type(1) would select summary item for reaction, .summaryItem:nth-of-type(2) would select summary item for memory, etc.

Aside from that, I recommend looking into semantic HTML tags in order to fix warnings in accessibility report and make the website more accessible.

Marked as helpful

0

Ohsandβ€’ 70

@ohsand

Posted

@danaYatsuta Thank you, that's a great idea, I'll do that next time!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord