Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Result-summary-compound

@mishalmusthafa

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am new to web designing and development. I used the grid and flex box in this project. I have created this with my own style. Can any one tell if this is a good way of doing this or is there a better way. Looking for some feedbacks

Community feedback

@LuisJimenez19

Posted

Hello! Congratulations on completing the challenge. It looks very good, these are some details that I notice can improve.

The <header> element has no function, you could omit it.

The background of the entire page is not completely white, it is something more or less like this background: #eef2fe;, you can add it <section id="result-summary"

You can add these rules to .container, it is no longer necessary to apply a background

.container {
    /* padding: 80px 20px; */
    /* background: #fff; */
    display: flex;
    align-items: center;
    justify-content: center;
    height: 100vh;
}

Very well used grid, I added these CSS rules to make the card look good:

.item-container {
    display: grid;
    grid-template-columns: repeat(2, 1fr);
    grid-gap: 20px;
    align-items: center;
    justify-content: center;
    background-color: #fff;
    border-radius: 16px;
    box-shadow: 0 10px 10px #c8d2ef;
}

It is generally better to manipulate the content from its container, so you can avoid using margin and do something like this in the summary:

.item-container .summary {
    padding: 20px;
    gap: 10px;
    display: flex;
    flex-direction: column;
}

and finally the .atributtion generates a scroll and in this case it is not necessary, unless you want it, I show you a possible solution so that it remains at the bottom and does not scroll:

.attribution {
    font-size: 11px;
    text-align: center;
    position: absolute;
    bottom: 0;
    width: 100%;
}

Very good job, I hope I have helped you, let me know if you have questions. Thank you!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord