Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

RFIX_Solution_QR-Component-Front-end-mentor

#sass/scss

@RPinero-20

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi everyone!👋🏻

Really enjoyed making this project!

Let me know how can I improve!

Thanks!

Community feedback

Naveen Gumaste 10,480

@NaveenGumaste

Posted

Hay ! Raul Pinero Good Job on challenge

These below mentioned tricks will help you remove any Accessibility Issues

-> Add Main tag after body <main class="container"></main>

-> Learn more on accessibility issues

If this comment helps you then pls mark it as helpful!

Have a good day and keep coding 👍!

Marked as helpful

0

@RPinero-20

Posted

@Crazimonk Hi! thank you very much for the advice! i´ll keep in mind next time, and next, and next, and ... 😁 forever

1
Yazdun 1,310

@Yazdun

Posted

Hey Raul great job on this, to get rid of accessibility issue, you must add a h1 heading to your main tag which tells what this page is about, it can be hidden, you can use a simple sr-only css class if you want to make it hidden.

right now, as your website hits around 337px width, QR card sticks to the edge of the screen which is not the best user experience IMO, so make sure to use some paddings on QR code's parent element.

in my opinion your box shadow is too thick, but hey, that's a personal opinion 😁

well done and keep coding !

Marked as helpful

0

@RPinero-20

Posted

@Yazdun Thanks Yazdun, i´ll change it 😁.

0
Hexer 3,680

@Phalcin

Posted

Great job overall man.

0

@RPinero-20

Posted

@Phalcin Thanks man! i´m on my way

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord