Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 11 months ago

Room homepage

bem, oocss, sass/scss
Yejin Han (한예진)•270
@Yejin-Han
A solution to the Room homepage challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I tried to subdivide the scss file. But there are not many styling contents, so I don't think I'll need it for a side project like this.

What challenges did you encounter, and how did you overcome them?

There is an unknown margin on the .swiper-slide using picture, img tags. I wandered around because I couldn't check it in the DevTools, but it was solved by giving the vertical-align value as top/middle rather than baseline as the default value of the inline tag.

What specific areas of your project would you like help with?

I just want you to do it if there's anything to point out in general. Also, please let me know how many hours would be appropriate to make this kind of page.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Maryam•260
    @Maryam1982
    Posted 11 months ago

    You did a great job for Carousel and responsive layout. I liked the timing for changing the text and images better than what i myself did. To make it even better I think you can decrease logo/nav-items margin as they seem too low. Also distance between your CTA (shop now) and navigation buttoms is too little.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub