Skip to content
Submitted over 3 years ago

Room Homepage made with HTML CSS JAVASCRIPT

chris•120
@SteffanVII
A solution to the Room homepage challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Needs tips for structuring my html and css, i tried to seperate my css file not sure if it's good practice. Also not sure if i code the image slider the better way. Any advice would be appreciated :)

Code

Please log in to post a comment

Log in

Community feedback

  • Carl Wicker•1,055
    @carlwicker

    Great job on the layout. However, if I remember rightly the text to right of main image is meant to change too with every image. The sliding images also seem to move up by a pixel once in place, not sure what's causing it but maybe take a look.

    Also fix that pesky accessibility issue in the report.

    Keep up the great work.

    Marked as helpful
  • P
    David Turner•4,130
    @brodiewebdt

    This came out great. I hope if I do this one it will look this good. The slider works fine. There are a lot of way to code a project. No one right or wrong way. Your code is clean and easy to read. I think when people separate stylesheets they import them into one main one. I don't what way is the best. You have an empty footer tag. Change the attribution div to a footer and it will clear the accessibility warning.

    Hope this helps.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord