Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Room Homepage using HTML CSS & JS

FesoQue•380
@FesoQue
A solution to the Room homepage challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is not perfect but I'm happy with the progress I'm making most especially in JavaScript. I need y'all reviews/feedback on this

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Andrew Kuzmichev•15
    @Arteaga71
    Posted over 4 years ago

    Hey, I would like to leave a feedback, would be better if:

    • Logotype should be interactive
    • The image which changes on arrows click is not correctly set, check the 940px width
    • Arrows below the shop now button should be interactive elements - buttons, instead of divs
    • Avoid overusing comments in any part of your code, even html, everything you are doing should be understandable without them - learn how to write clear code, understandable for other devs, besides edge cases
    • Use eslint for javascript, it will make it more clear
    • On small screen size the logotype is too far from the menu
    • Hamburger menu is not interactive - can't use it from keyboard, it is accessibility issue, think about accessibility not about something additional to your good site, accessibility are the default behaviour which we break applying wrong practices
    • Do not make more sense to keep you minified javascript in repository, but can be variants

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub