Room Homepage using HTML CSS & JS

Solution retrospective
This is not perfect but I'm happy with the progress I'm making most especially in JavaScript. I need y'all reviews/feedback on this
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Arteaga71
Hey, I would like to leave a feedback, would be better if:
- Logotype should be interactive
- The image which changes on arrows click is not correctly set, check the 940px width
- Arrows below the shop now button should be interactive elements - buttons, instead of divs
- Avoid overusing comments in any part of your code, even html, everything you are doing should be understandable without them - learn how to write clear code, understandable for other devs, besides edge cases
- Use eslint for javascript, it will make it more clear
- On small screen size the logotype is too far from the menu
- Hamburger menu is not interactive - can't use it from keyboard, it is accessibility issue, think about accessibility not about something additional to your good site, accessibility are the default behaviour which we break applying wrong practices
- Do not make more sense to keep you minified javascript in repository, but can be variants
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord