@pikapikamart
Posted
https://www.w3.org/WAI/tutorials/carousels/
Hey, awesome work on this one. Just saw the site and it looks really great in desktop view, the site is responsive and the mobile state looks great as well.
For some suggestions, here are some:
- You could put a
max-width
andmargin: 0 auto
on thebody
tag. If you zoom out on your screen, you will see that the layout just kind of expand along which causes the layout to be destroyed. Adding thatmax-width
would be nice so that the layout will be capped and controlled properly for users who have large screens. - Website-logo-link
a
tag should have eitheraria-label
attribute orsr-only
text inside, that describes where the link would take the user. Usually, website-logo directs user to homepage so usehomepage
as the value like `aria-label="homepage". - Just to note that creating a carousel is really hard especially making it accessible. Just going to put this link up if you want to read about creating accessible carousel. You just kind of scroll to the bottom and click the next page since it guides you from the start to finish on how to create one.
- Each arrow-svg on the
button
should have usedaria-hidden="true"
so that it won't be picked up by screen-reader. - Also, on those other images where you used
alt=""
, adding an extraaria-hidden="true"
on it as well would be really nice, just to ensure it is skipped.
MOBILE
- The
svg
as well for the hamburger could have usedaria-hidden="true"
.
Aside from those, again the site looks nice and great job again on this one.
Marked as helpful