Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Room homepage using Sass and Bootstrap 5

#bootstrap#sass/scss
Byron 2,180

@byronbyron

Desktop design screenshot for the Room homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello ladies and gentlemen! Here's my version of the Room homepage using a pretty standard Bootstrap setup with Sass and Laravel mix. Hope you like it!

Community feedback

@pikapikamart

Posted

https://www.w3.org/WAI/tutorials/carousels/

Hey, awesome work on this one. Just saw the site and it looks really great in desktop view, the site is responsive and the mobile state looks great as well.

For some suggestions, here are some:

  • You could put a max-width and margin: 0 auto on the body tag. If you zoom out on your screen, you will see that the layout just kind of expand along which causes the layout to be destroyed. Adding that max-width would be nice so that the layout will be capped and controlled properly for users who have large screens.
  • Website-logo-link a tag should have either aria-label attribute or sr-only text inside, that describes where the link would take the user. Usually, website-logo directs user to homepage so use homepage as the value like `aria-label="homepage".
  • Just to note that creating a carousel is really hard especially making it accessible. Just going to put this link up if you want to read about creating accessible carousel. You just kind of scroll to the bottom and click the next page since it guides you from the start to finish on how to create one.
  • Each arrow-svg on the button should have used aria-hidden="true" so that it won't be picked up by screen-reader.
  • Also, on those other images where you used alt="", adding an extra aria-hidden="true" on it as well would be really nice, just to ensure it is skipped.

MOBILE

  • The svg as well for the hamburger could have used aria-hidden="true".

Aside from those, again the site looks nice and great job again on this one.

Marked as helpful

0
Byron 2,180

@byronbyron

Posted

Cheers dude!

  • I did put a max-width and margin-left/right: auto on the body halfway through, but then changed my mind for some reason 😅
  • The logo image alt counts as discernible text but like you point out, it has to describe where the link goes, so I've just removed the link as there's a home link next to the logo anyway.
  • I agree that carousels can be an accessibility pain. For this project, though, I've just copied Bootstrap's as it allows navigation with the left and right keys, and I didn't want to over engineer it.
  • Sorted the aria-hidden="true" on the menu and arrow svgs 👍
  • For the other images with alt="", I've just given them some appropriate alt text instead of leaving them blank.

Thanks again for the feedback!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord