Room homepage ( with SASS, with vanilla HTML and JS)

Community feedback

• 

  P

  Andrey•4,320

  @dar-ju

  Posted 26 days ago

  Hi BarrieDirk!

  Great work!

  I noticed a few details for improvement:

  • at a screen width of about 900px - 1050px the sections fly apart in height, check if it should be like this?
  • at a screen width below 900px when sliding in the first section the content in the second section jumps. Visually it is not very nice. This is due to the different number of lines in <p>, it is better to set this tag to something like min-height: 100px;
  • check the html code there are errors, for example the <title> tag is duplicated, link icon and so on. Also - An img element which has an alt attribute whose value is the empty string must not have a role attribute, this is an error

  Otherwise everything is great, you tried really hard!

  10

  Marked as helpful
• 

  Harsh Kumar•3,350

  @thisisharsh7

  Posted 26 days ago

  • You’ve done a fantastic job implementing SASS and organizing your styles clearly. It’s evident that you have a good grasp of nesting and variables, which really helps keep the code clean and maintainable.
  • The overall layout looks great on desktop screens — well-structured and visually appealing.
  • To take this project to the next level, focusing a bit more on responsiveness would really enhance the user experience on different devices like tablets and mobiles. This will help ensure your design looks just as polished across all screen sizes.
  • Keep experimenting with media queries and flexible units like percentages or rem to improve adaptability.
  • Overall, your work shows a solid foundation and a great understanding of SASS. Keep up the awesome progress — you’re definitely heading in the right direction!

  10

  Marked as helpful