Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

room-homepage-master with splide.js

@kkzio

Desktop design screenshot for the Room homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


I have issues about my button arrow for slider, hope give me so advice

Community feedback

P
Ken 4,915

@kens-visuals

Posted

Hey @kkzio 👋🏻

I have some suggestions on how to fix the accessibility issues.

  • Most of the issues are caused because in your <ul> you're not using <li>, so if you put those <div>s inside an <li>, it should fix most of the accessibility issues.
  • I think instead of using <header> it should be <main>, because that's the main part of the page. And <div class="attribution">...</div> it should be <footer class="attribution">...</footer>
  • I'd suggest putting the logo in a <span> or some different tag other than a heading. You can use <h1> on the headings of the slides.

I hope this was helpful 👨🏻‍💻 after you fix the accessibility and HTML, make sure to generate a new report. Since I haven't done the challenge, I cannot give feedback on the layout or styles, but it looks good to me 🤔 Cheers 👾

Marked as helpful

1

@kkzio

Posted

@kens-visuals Thank for your advice sir

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord