Sass and js

Community feedback

• 

  tediko•6,700

  @tediko

  Posted about 4 years ago

  Hello, Chris! 👋

  Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. Here's my few tips:

  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • Change the alt attributes for the .about__img images, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.

  Good luck with that, have fun coding! 💪

  23

  Marked as helpful
• 

  soransh singh•1,025

  @soransh-singh

  Posted about 4 years ago

  greattt workkk.... I liked your menu button and arrow icon animation ... will try to add something similar in my project... nice work...

  11
• 

  Julian Ifesiokwu•475

  @JulianIfesiokwu

  Posted about 4 years ago

  Solid effort, i think you missed using the right fonts for the client job description. How did you get the underline completed on the "LEARN MORE"? Also how did you get the logo to be green in the footer? Solid effort though.

  13