Hello, Chris! 👋
Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. Here's my few tips:
- Add
:focus
pseudo class to interactive elements like anchors, buttons etc. Useoutline
property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default:focus
pseudo class withoutline
property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles. - Change the
alt
attributes for the.about__img
images, as they don't add any extra context for screen reader users. Since your images are decorative youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies.
Good luck with that, have fun coding! 💪
Marked as helpful
@chrisbailey85
Posted
@tediko thank you, I keep forgetting about setting the focus. As a rule of thumb should you genuinely leave the alt empty unless it's has very important information on it?
@chrisbailey85 Yes, a decorative image is an image that adds visual appeal to the site without adding any additional important information. This image could strictly be a visual decoration. Read about Decorative Images. Image Accessibility 101.
@chrisbailey85
Posted
@tediko thank very much