Skip to content
Submitted almost 4 years ago

sass. parcel, netlify

kevin•415
@imonaar
A solution to the Social media dashboard with theme switcher challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Second Project. social-media-dashboard-with-theme-switcher. Feedback & corrections will be appreciated.

Code

Please log in to post a comment

Log in

Community feedback

  • P
    Dave•5,295
    @dwhenson

    Hey @imonaar - really lovely job on this one!! 🙌 I've not much to add to be honest. I'd just have a double check of some the html attributes you are adding, a couple of caught my eye are:

    1. Adding the role of 'region' to the div. I'm not sure this is really needed or it adds anything for assistive tech users. You may know more than me on this one though?

    2. Similarly, I'm not sure the aria-label is really needed on the section? This is very much a personal opinion though! But the h1 should probably cover this for you?

    The only other suggestion I have is to use the text-transform CSS property to change text to uppercase. This just makes it less hassle to change things around later if the design changes.

    But these are all very small points! Great one!! 👍

    Cheers 👋

    Dave

    Marked as helpful
  • kevin•415
    @imonaar

    I will check it out. Thank you!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord