Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

sass. parcel, netlify

kevin 415

@imonaar

Desktop design screenshot for the Fylo dark theme landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I think i did something here. Feedback and corrections welcome

Community feedback

P
Fluffy Kas 7,715

@FluffyKas

Posted

Hiya, your solution looks good! There's a few things to correct though!

  1. Email validation: it lets me submit an incorrect email format, it only warns me if it's empty or if it's less than 8 chars.

  2. Your social links have aria-hidden on them. I don't think this is what you're looking for here, as you don't want to deny access to certain features from visually impaired users. Aria-labels would me more correct here, so they can still see that there are links leading to social media sites, and aria-labels would give them description of these links!

Well done on completing this challenge though, it's a big job :)

Marked as helpful

1

kevin 415

@imonaar

Posted

@FluffyKas Thank you for having a look. Letme correct and get back to you

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord