
Solution retrospective
tried to finish this page in 1:30 hours
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Finney06
Hello there 👋. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML 🏷️:
To clear the Accessibility report:
-
Wrap the page's whole main content in the
<main>
tag. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections.
I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!
-
- @LoaiEsam37
to make the perfume word become like the design you can use letter-spacing property in css to increase the space between letters in the word also this is an extra tip you can use line-height property to increase or decrease the spacing between lines
happy coding
- @LoaiEsam37
add role main to your <div class="container"> tag like this <div class="container" role="main"> or you can just do it like this <main class="container"> and the idea here is to make it more easier for screen readers to know where is the main content and you can also use something like <nav> , <footer> and <sidebar> tags for the same reason. also here:
<p>perfume</p> <h1>Gabrielle Essence Eau De Parfum</h1>
you have to make it like this
<h1>perfume</h1> <p>Gabrielle Essence Eau De Parfum</p>
because the page have to start with h1 and then you can change the font-size from css
hope you find this helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord