Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

SCSS, Media Query Function

sass/scss
topspinppy•80
@topspinppy
A solution to the Stats preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Please Feedback I learned scss first time, I'm not sure about scss best practice :D

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Marvin Baga•310
    @mjbaga
    Posted over 3 years ago

    Hi @topspinppy. Good job on the challenge.

    I've checked your code and have a few feedback:

    • I would recommend to separate your media queries in big group chunks, instead of repeating the media query includes on a few declaration blocks. It's something I also used to do, but when you check your compiled styles.css, you'll see the same media queries were repeated like 16 times on the file. It wouldn't matter much on very small projects but quite significant or large ones, even saving a few kilobytes.
    • You can check out mobile-first development. It helped me out a lot in coding for responsive design. Basically it's coding for mobile first and adding media queries as you go up in screen size. So you'll be using your min-width mixins instead of max-width.

    That's it. Hope this helps! Happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub