Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Tip Calcuator React

#react
namlh 630

@namlh023

Desktop design screenshot for the Tip calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I've got an HTML issue that says "Element label not allowed as child of element div in this context. (Suppressing further errors from this subtree.)". Any ideas on how to fix this? Thanks a lot.

Community feedback

@maqsudtolipov

Posted

Hi there 👋

Congratulate on finishing your project 🎉. The design looks beautiful 😃. Functionality is also working well ⚙

Ryan, there are no HTML issues 😀, I mean there was a typo I guess. You have written as <lable> which should be <label> 🐜

Happy coding ☕

Marked as helpful

0
Fraser Watt 1,790

@fraserwat

Posted

Hey, this is looking good! Couple of things i'd change:

  • I'm not quite sure the calculations are correct on the tip %, I enter $50 bill between 2 people at 50% tip and it says tip is $0.25
  • Your html validation issue might just be a typo <lable> as opposed to <label>
  • Would also quickly include your logo in <h1> tags as a screen reader would expect a header somewhere on page (you've got alt text in there so it still works)

Great stuff though!

Marked as helpful

0
namlh 630

@namlh023

Posted

Thanks, guys

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord