@TalhaAmjad0034
Posted
Seems perfect to me.
@Dike-Code
Posted
@arywahhh Thank you, I really appreciate.🙌
Looking to hire developers?
Hi Everyone!! What do you think of my first "FrontendMentor Challenge? Please do well to put down your opinions and suggestions of it... so for me to know what works better and what doesn't.
@TalhaAmjad0034
Posted
Seems perfect to me.
@Dike-Code
Posted
@arywahhh Thank you, I really appreciate.🙌
@jomefavourite
Posted
Hello Clinton, you did a very good job on your first challenge and here're my suggestions.
I noticed that the section
element with the class name site
has a div
element with an image element with no src
attribute link which produces an unnecessary space in the layout. I suggest removing that div
element.
Also, I suggest applying a max-weight
property to the paragraph p
elements in other for the text not to be stretched out on bigger screens.
Also the images, should have a max-weight
property applied. For example:
.device_showcase .device {
width: 75%;
max-width: 1000px;
}
main
element. Well, this is my personal structure though. Example below<header>...</header>
<main>...</main>
<footer>...</footer>
@Dike-Code
Posted
@jomefavourite. Thanks a lot... I'd sort and amend the errors.
@erickwalker1
Posted
Wassup man, seems your preview site is rendering a 404. Maybe you mistyped the url?
@Dike-Code
Posted
@erickwalker1 Yeah, have sorted it out.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord