Skip to content
Submitted almost 2 years ago

Semantic HTML5 markup CSS custom properties Flexbox CSS Grid

salahstack•210
@salahstack
A solution to the Clipboard landing page challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in

Community feedback

  • Thomas Hertog•865
    @thomashertog

    The design is a bit too much off to consider this one finished in my opinion. Most of it is colors and sizing, so you're on your way there.

    Other improvements I'd make on this

    HTML/accessibility

    • you have a lot of <div> containers of which i'm not sure whether they're all needed/adding some possibilities
    • There's a <header> and <footer> which is good but no <main>
    • <section> without associated header is just the same as a meaningless <div>

    CSS

    • mobile-first vs desktop-first is implemented inconsistently
    • a lot of px-values which are better in em/rem
    • you clearly know about some of the (which i consider) more advanced features of CSS Grid, however, you seem to be applying them in the wrong place/manner which causes weird composition (e.g. your footer at about 890px wide)
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord