Showkat/my-recipe-page-solution

Community feedback

• 

  beowulf1958•1,890

  @beowulf1958

  Posted about 1 month ago

  Congratulations on completing this challenge. Your html is clean and clear and the styles are easy to understand. The box-shadow is awesome: subtle but effective. You have picked up on the color change on the list bullets and correctly used ::marker. (however you missed that the numbers on the ol are also orange) <ol class="orange-bullets"> Also I like how you used table th:nth-child(2) to target the numbers. I do have a few suggestions.

  First, the image is not showing up due to an incorrect file path. The jpg is in the root folder and you are directing the browser to look in a subfolder called assets. The correct path is <img src="image-omelette.jpeg" alt="Omelette" class="recipe-image"> Second the Nutrition heading is not showing up because the h2 opening tag is missing a bracket. You have <h2 style="color:hsl(14, 45%, 36%) ;" Nutrition></h2> which should be <h2 style="color:hsl(14, 45%, 36%) ;"> Nutrition</h2>

  Next the table does not have a border-bottom in the design. To fix this add a style to the las two th

  <th style="border-bottom:none">Fat</th>
  <th style="border-bottom:none">22g</th>
  

  I also think you should consider giving the body element a background-color to better distinguish the card from the page (maybe Rose 50: hsl(330, 100%, 98%) ?)

  Again, great job and keep on coding!

  01