Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Signup Form - SCSS

Pon Huang•210
@ponhuang
A solution to the Intro component with sign-up form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I am a newbie in JavaScript, this form validation is quite hard for me now. I was learning via YouTube video. However, here is one problem I have in JavaScript.

The error icon and error message only shows up the first input, and I guess is the querySeletor only pick up the first element class. But if I use querySelectorAll, it is going to be an array, and it won't work as well. In this case, how can we make it work? Is there any better way to write this code?

For designing part, there is one part I want to optimize. How to make the error icon to align center with placeholder? I use flexbox and align-items to center, but it is not working. If you know how to fix it, please let me know. Appreciate for advance.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Nurcholis•420
    @cholis04
    Posted almost 3 years ago

    Hi Pon Huang. Great job on this challenge!

    Looks like you're having a little trouble in this challenge. Let's take a look at the problem you're having:

    - Error icon and message appear only on first input

    All icons and error messages have the same class name. So you need to tell the browser specifically which icon and error message is given the class name 'hidden'

    You can select the icon and error message based on the input element itself :

    const  invalidateElement = (element) => {	
    	const currentElement =  element;
    	const errorIcon = currentElement.nextElementSibling;
    	const errorMessage = currentElement.parentElement.nextElementSibling;
    
    	currentElement.classList.add('invalid');
    	errorIcon.classList.remove('hidden');
    	errorMessage.classList.remove('hidden');
    };
    

    You can do the same for your reset element function. So you don't have to select icons and error messages by document, you can delete the previous code :

    
    const errorMessage = document.querySelector(".error-message"); // remove this line
    const errorIcon = document.querySelector(".error-icon"); //remove this line
    

    - Error icon not center align

    You should remove the margin-bottom property on the input tag.

    input {
    	display: block;
    	width: 100%;
    	height: 5.6rem;
    	/* margin-bottom: 0.6rem;  Remove this line */
    	padding-left: 2.5rem;
    	font-family: inherit;
    	border: 1px solid $color-grayish-blue;
    	border-radius: 5px;
    }
    

    Maybe a little suggestion, you should give the margin-top and margin-bottom properties with the value 1rem in your error message.

    Hopefully can help. Happy coding

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub