Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Sign-up form with HTML, CSS and vanilla Javascript

solvman•1,650
@solvman
A solution to the Intro component with sign-up form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback is highly welcome. Specifically, I'm looking for feedback on:

  • The structure and semantics of my HTML
  • The use of CSS custom properties and layout techniques (Flexbox and Grid)
  • The form validation logic in my JavaScript code.

Thank you in advance for your time and feedback.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Bishal Singh Deo🎮•1,440
    @Bishalsnghd07
    Posted over 1 year ago

    Hi, @solvman 👋

    Congrats for completing this challenge 🎉 and you did terrific job👏

    1)There is a tool in the browser called lighthouse. By inspecting in your browser you can get the option lighthouse testing. This feature, will test your web page performance, accessibility, best practice and SEO. This tool will decrease developer workload and gives accurate result.

    2)text-align should be used in the child div not in parent div by giving text-align:center; in body, means you are giving text-align: center in your all child div's. This will make your whole text in center and break the consistency of project. I'm Just giving you this tips to make better your code usability.

    Hope, this tips will help you ahead in future projects, other than that great job!

    Happy Coding ❤️

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub