Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 9 months ago

Simple and responsive landing page using CSS

Tee12thegreat•80
@Tee12thegreat
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

i was able to write most of the html code without looking at other work. i was impressed with the media queries in CSS and how my webpage fitted on my phone web. next time, i would give myself more time to play around with CSS

What challenges did you encounter, and how did you overcome them?

i could not create the mobile version of the application. i then looked up for some solutions on the internet

What specific areas of your project would you like help with?

i would like more help in CSS, i still have a long way to go despite grasping the basics in theory

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Wisdom•230
    @Unifies
    Posted 9 months ago

    Hi there, Takomborerwa. Great work completing your first challenge on Frontend Mentor, your solution to the challenge looks good. Kudos on overcoming the challenge you had, because the layout & mobile view of your solution looks great and responsive on all active screen widths.

    A couple updates for better code quality:-

    Include semantic HTML and a level one heading in your code - It is best practice to contain all content within distinct regions such as the <header>, <nav>, <main>, and <footer>. Here's a guide to the full doc that explains this.

    Your solution differs slightly from the design because you have the <attribution> code in the QR Code Component. That is the part with the "Challenge by, Coded by", it's supposed to come underneath the solution OUTSIDE the white qr_code div but within the body inside the "attribution" div. This will of course mean you have to rewrite the stylings for the attribution section so that it looks as it should.

    Marked as helpful
  • Ahmed Zaki•30
    @AhmedMahmoud6
    Posted 9 months ago

    Well Done, you can make the spacing between the elements more cleaner and easier by using the display flex on the parent and use the following code or try to see my solution

    display: flex;
    flex-direction: column;
    gap: 20px; // change the pixels as you want
    

    this is more cleaner than giving each element a margin top or bottom.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub