Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Simple card using HTML,CSS (Flex-box).

@satya-hash

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please feel free to write your opinion on the challenge. I really look forward to hearing from you. Please let me know anything that I'm missing. Thank you.

Community feedback

Fat 850

@Fahatmah

Posted

Great work there!

I just see in your report that you have some accessibility issues. Main issue is not using semantic HTML which are main, section, footer and this will avoid the issues in your code. Although you used section tag, it shoud have the main tag first. But nice job done there. Hope this helps you.

Marked as helpful

1

@satya-hash

Posted

@Fahatmah Thank you for the feedback. And I try my best to resolve the issues and improve my skills.

1
Vanza Setia 27,855

@vanzasetia

Posted

Hello, @satya-hash! 👋

Good effort on this challenge! 👍

Some recommendations from me.

  • Always specify the type of the button. In this case, set the type of them as type="button". It will prevent the button from behaving unexpectedly (like submitting).
  • The value for the href attribute of <a href="*">Change</a> is visiting to "Page Not Found". I would recommend using a number sign or forward slash instead.
  • There should not be text in span and div alone whenever possible. Instead, wrap the text with a meaningful element like a paragraph element.

That's it! I hope you find this useful! 😊

Marked as helpful

0

@satya-hash

Posted

@vanzasetia Thank you for your help and support. I will try my best to correct my mistakes and improve my skills 🙂.

0
Vanza Setia 27,855

@vanzasetia

Posted

@satya-hash Happy to help! 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord