@elidrissidev
Posted
Amazing work Aliaa! Not bad for a first challenge. Keep it up!
For the images problem, it's because of the URL you're using:
http://127.0.0.1:5500
is a URL only accessible on your machine when you were running the http server (Using Live Server Vscode extension?).file:///Users/...
is a URL used to access files on your local filesystem (Mac in this case) and is again specific to your system and won't work elsewhere.
So the fix for this is to use a relative URL, in your case it's gonna be ./images/<image name>
.
As for the rest I only have 3 suggestions:
- Every html page should have a level 1 heading
h1
that describes the main content of the page. - Consider using semantic html elements instead of generic
div
s where appropriate, for example the "Cancel" text can be inside aa
or abutton
element because it conveys that it can interacted with. - Check the accessibility report page for more.
Good luck to you!
Marked as helpful
@aig0041
Posted
@elidrissidev Oh yes I was using the live server extension. I didn't realize what the correct URL was though, but i changed it now and it works so thank you so much! I also really appreciate all the suggestions; I'll definitely keep them in mind.
@elidrissidev
Posted
@aig0041 you're welcome!