Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 6 months ago

Simple interactive rating component using native javascript

progfish•280
@progfish
A solution to the Interactive rating component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am most proud of completing the challenge by using native javascript and not some SPA Framework like Angular.

What challenges did you encounter, and how did you overcome them?

None that I can think of

What specific areas of your project would you like help with?

Code feedback is always appreciated. But as a note, this challenge was completed using the bare minimum required :)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Aakash Verma•9,500
    @skyv26
    Posted 6 months ago

    Hi @progfish, 😊

    First off, I want to say that I really appreciate your design work! The app looks great and feels polished despite the minimal resources you had to work with. Awesome job! 👍 However, there are a few areas where improvements can be made to optimize both your code structure and maintainability. Here are my suggestions:

    1. Separate Design from HTML: It's always a good practice to separate CSS into its own file rather than embedding it directly within the HTML. This makes your code more readable, easier to maintain, and better structured for future updates. 📂

    2. Use <ul> and <li> for List Items: For the ratings section, it's better to use <ul> (unordered list) and <li> (list item) tags instead of <div> for each item. It makes the HTML more semantically correct and improves accessibility. It will also help screen readers interpret the content better. 📝 Example:

      <ul class="ratings">
        <li class="circle" onclick="setFeedback(event, 1)">1</li>
        <li class="circle" onclick="setFeedback(event, 2)">2</li>
        <li class="circle" onclick="setFeedback(event, 3)">3</li>
        <li class="circle" onclick="setFeedback(event, 4)">4</li>
        <li class="circle" onclick="setFeedback(event, 5)">5</li>
      </ul>
      
    3. Use <div> Instead of <section>: The <section> tag is typically used to represent distinct sections of a website with their own headings. For a small card like this, you can simply use a <div> tag, as it is more appropriate for this use case. 🚫🗂️

    4. Use Meaningful or Empty alt Attributes for Decorative Images: If the image is purely decorative, you can leave the alt attribute blank (alt=""). However, if it adds context, make sure the text is meaningful. This is important for accessibility and how screen readers will interpret the image. 🖼️

    5. Externalize JavaScript: For better code organization and reusability, consider placing your JavaScript code in a separate file and linking it to the HTML. This will help keep things clean and modular. 📜

    Great work overall, and keep it up! 🚀

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub