@ApplePieGiraffe
Posted
Hi, Iva Beriashvili! 👋
Good work on this challenge! 👍
I'd like to suggest using more semantic HTML elements in your markup, which is important for accessibility and SEO-related reasons. For instance, the card could be an article
element, the name inside it could be a heading element, and the list of stats at the bottom of the card could be a ul
element. If you’d like to learn more about how to write semantic HTML and why it matters, check out this short, helpful course.
As for the background images in this challenge, they can be tricky to place! I found that using a combination of viewport units and percentages worked well to keep the images more or less in their position as the screen resizes. If you're interested in checking it out for any ideas, you can do so here. 😉
Hope you find this helpful. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful
@ivaberiashvili
Posted
@ApplePieGiraffe Thank you for your feedback,
I'm aware of the importance of SEO but didn't pay much attention to semantics this time.
I checked your solution and the touch of animation is so cool! and the background are also close to design. However I was thinking to bring them as elements and give them absolute positioning related to the card itself, because if you look closely the overlap of those circles are almost identical on desktop and mobile.