Simple QR code page

Community feedback

• 

  YounusUID•0

  @YounusUID

  Posted almost 2 years ago

  I suggest following improvement in your CSS code. I just write CSS that should be remove or edit.

  .card {   
      width: 300px // set width 300px, after adding 15px left/right padding, the actual size will 
                                  300 + 15 + 15 = 330  
      height: 500px; // remove this line
      border: none;  // remove this line
      padding: 15px; add this line for add padding to entire box
  }
  .qr-code {
      width: 100%; // set width to 100%
      margin: 16px auto 0 auto; // remove this line
  }
  .title {
      width: 250px; // remove this line
      margin: 0 0 20px 0; // add margin bottom
      text-align: center;  // remove alignment from here and add to the parent div
  }
  .description {
      width: 250px;  // remove this line
      height: 100px;  // remove this line
      margin: 0; // set margin 0
      text-align: center;   // remove alignment from here and add to the parent div
  }
  

  Wrap title and description into a div and add padding to set spacing around the div. i.e.

  .xyz {
      text-align: center;
      padding: 20px;
  }
  

  00
• 

  P

  Alexandra•580

  @Alexandra2888

  Posted almost 2 years ago

  Hi! Congrats for finishing challenge. Your solution is very close to the design! Here are some things I think you can improve:

  • reset default CSS with *, *::after, *::before {margin:0; padding:0; box-sizing:border-box};
  • convert px to relative units (em/rem). Coding in px is usually for magazines/newspapers when you need fix units,
  • make variables in :root{} ex for colors here,
  • implement BEM naming convention eg .card__qr-code {}. I t will help you in bigger projects and wh you will use SCSS. Happy coding!

  02