Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Simple QR Component

Josh Eberharterβ€’ 380

@jeeberharter1

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Anosha Ahmedβ€’ 9,340

@anoshaahmed

Posted

hey good job on this challenge! your report above shows a few issues though:

  • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
  • you should have at least one <h1> in your webpage

here is a list i made of accessibility issues & best practices

hope this helps :))

Marked as helpful

0

Josh Eberharterβ€’ 380

@jeeberharter1

Posted

@anoshaahmed thanks for the feedback! I looked through that list and found a lot of it helpful :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord