Account Deleted
Hey Ilya, congratulations on completing the challenge! You did a great job 😉
Let me give you some little tips for optimizing your code:
- add
main
tag and wrap the card for improve the Accessibility - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - instead of using
margin
for the internal space of element, usepadding
property tocontainer
class - centering a
div
withabsolute
positioning is now deprecated, it uses modern css likeflexbox or grid
- use flexbox to the body to center the card. Read here -> flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding 😁 by Travolgi
Marked as helpful
1
Elias Ekornås• 60
@DrRuski
Posted
@travolgi Thank you for feedback, i will take this into consideration for my next project.
1
Account Deleted
@DrRuski you are welcome! Keep it up :)
0