
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Stroudy
Hey, Great job with this solution you should be proud, A few things I noticed,
- Missing a
<meta>
description tag for SEO purposes, - It is best practice to have a
<main>
tag inside your body highlighting the main section. - There is no
:hover
effect when the mouse is over the links, easy fix CSS :hover Selector - Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
- You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻
Marked as helpful - Missing a
- P@adamwhitehouse95
Nice! Close to the design, few things could be altered though
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord