Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Single column coming soon page using HTML + CSS + Vanilla Javascript

Jose Angel Reyβ€’ 395

@Jose-Angel-Rey

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi everyone, any feedback to improve my code is really appreciated πŸ™πŸΌπŸ‘¨πŸΌβ€πŸ’»

Community feedback

P
tedikoβ€’ 6,580

@tediko

Posted

Hello, Jose! πŸ‘‹

Nice work! I really like how your solution responds. A little hint from me:

  • Since your main-content__illustration image is decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.
  • social-media icons should be wrapped in anchor tags so I can select them.
  • Your footer isn't centered vertically.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

Good luck with that, have fun coding! πŸ’ͺ

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord