Thomas Hertog• 715
@thomashertog
Posted
like you said, it's not perfect yet, my suggestions to you
Design
- Have a look at the colors in the
style_guide.md
from the starter files, the ones you use, feel a bit darker on screen - the 2 sections at the bottom are not equally wide in your solution
HTML
- you're missing a landmark
- you're missing an
<h1>
, remember headings should be in order and never skip a level
CSS
- there's a lot being done with
px
values, try to replace them withem
orrem
for better accessibility - I feel you have some rules duplicated in your code. Didn't find a particular example, but I saw it passing by
Marked as helpful
0