Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Single price grid component

#sass/scss
Pedroβ€’ 120

@pedrommb7

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What do you think about this solution ? What could be enhanced ?

Community feedback

Ahmed Bayoumiβ€’ 6,800

@Bayoumi-dev

Posted

Hey Pedro, Congratulations on completing this challenge... You have accessibility issues that need to fix.

  • Document should have one main landmark, Contain the component with <main>.
<main>
   <div class="grid">
      //...
   </div >
</main>
  • Heading levels should only increase by one, Use h2 instead of h3... Ordered headings make it easier to navigate and understand when using assistive technologies.

  • I suggest you put the Why Us content into the list item to add more semantics to your project.

<ul class="why-us-list">
   <li>Tutorials by industry experts</li>
   <li>Peer & expert code review</li>
   <li>Coding exercises</li>
   <li>Access to our GitHub repos</li>
   <li>Community forum</li>
   <li>Flashcard decks</li>
   <li>New videos every week</li>
</ul>

I hope this is helpful to you... Keep codingπŸ‘

1
Abdulβ€’ 8,560

@Samadeen

Posted

Hey!! Cheers πŸ₯‚ on completing this challenge.. .

Lets firstly work on your accessibility issues.

  • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="grid"> instead of <div class="grid">.
  • You should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

This should fix most of your accessibility issues.

. Regardless you did amazing... hope you find this helpful... Happy coding!!!

0

Ahmed Bayoumiβ€’ 6,800

@Bayoumi-dev

Posted

@Samadeen I already suggested how to solve the issues What point is valuable and different in your suggestions?!!!!

0
Abdulβ€’ 8,560

@Samadeen

Posted

@Bayoumi-dev Excuse you?? Do you want 1st so bad i can actually back down bro.. No need to come at me like that..

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord