Single price grid component - HTML, CSS Grid, Media query

Solution retrospective
My second try with css grid.
As always, If someone could give me some feedback to improve my skills, I would really appreciate it.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @vanzasetia
👋Hi Nene! My name is Vanza!
I have some feedback on this solution, that may improve this solution:
- For the
container
, I recommend to usemax-width
as a default style, not inside@media all and (min-width:1024px)
. The problem with putting thewidth
inside this media query is that, it will only applied when the screen is1024px
and above. So, when the screen size is960px
thecontainer
will become too wide. - For the zero number, the best practice is that never put a unit on zero number, because
0
is equal to0px
,0%
,0rem
and etc.
That's it! Hopefully those feedback will improve your skill!
Happy Coding and Keep Learning!
Marked as helpful - For the
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord