Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 months ago

Single price grid component

Tetiana•540
@TetianaAleks
A solution to the Single price grid component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What specific areas of your project would you like help with?

I’d really appreciate any feedback on my solution, especially regarding code structure, accessibility and responsiveness.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Asilcan Toper•2,960
    @KapteynUniverse
    Posted about 2 months ago

    Hey Tetiana, nice job.

    Your usage of landmarks and headings and also responsiveness looks good. Sizes are kinda odd tho, like gap: 0.46rem; but i guess you wanted to make pixel-perfect like Yacoub said.

    For accessibility i see 2 issues:

    1. Everything has a bad color ratio, which is not your doing but the design is bad for that matter. For the future; you can see this by hovering any text with inspect tool and look for the contrast. You can check here for that criteria

    2. Outline and border none is not good for accessibility. When i try to focus "Sign Up" button with the tab button on keyboard, i can't see if i am on the button. So either you want to use border-color: transparent; or outline-color: transparent; or need to make a custom style for that.

    Marked as helpful
  • Yacoub AlDweik•3,540
    @YacoubDweik
    Posted about 2 months ago

    Good job!

    Always wanted to ask u, where do you get all these media queries values from? 640px and 426px (not 425px lol haha). Like I've never seen anyone uses these values?!?

    Also why on earth would you give min-height to that card article?! You always give heights and widths but in terms of max-width and min-height which won't be a problem that causes any overflow but it will look odd if the content gets smaller or if the font size gets smaller, I think you want to achieve pixel-perfect designs like me when I started solving these challenges haha. Just wanna say weel done and keep it up Tetiana!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub