Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Single price grid component using CSS Grid, Flexbox, and HTML5

@rngueco

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Is there anything I could have done to either optimize or organize my code better? Any feedback regarding how to structure elements or styles better would be much appreciated.

Community feedback

P
Katrien S 1,050

@graficdoctor

Posted

Hello Riyana, I like your code. It looks very clean and structured.

Just some minor remarks. Don't put a px-fontsize on the :root. There's people that have adjusted their browser to a bigger or smaller fontsize. By putting a fixed size on the :root, you force these people to read the size at 16px. I put my fontsize always on the body, in em. 16px is 1em. So people who haven't changed their settings still see the 16px, those who have, see a font that is equal to their setting.

Ditch the min-width on your main. Or make it smaller. An iPhone 5's min-width is 320px. And I heard there's a Samsung phone going for 285px.

Happy friday and keep on coding!

Marked as helpful

0

@rngueco

Posted

@graficdoctor Ah, didn't know about the font-size in :root thing, thank you!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord