Skip to content
Submitted almost 4 years ago

Single price grid component using CSS Grid, Flexbox, and HTML5

Riyana Gueco•495
@rngueco
A solution to the Single price grid component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Is there anything I could have done to either optimize or organize my code better? Any feedback regarding how to structure elements or styles better would be much appreciated.

Code

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Katrien Schuermans•1,400
    @katrien-s

    Hello Riyana, I like your code. It looks very clean and structured.

    Just some minor remarks. Don't put a px-fontsize on the :root. There's people that have adjusted their browser to a bigger or smaller fontsize. By putting a fixed size on the :root, you force these people to read the size at 16px. I put my fontsize always on the body, in em. 16px is 1em. So people who haven't changed their settings still see the 16px, those who have, see a font that is equal to their setting.

    Ditch the min-width on your main. Or make it smaller. An iPhone 5's min-width is 320px. And I heard there's a Samsung phone going for 285px.

    Happy friday and keep on coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord