Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

Single price grid component using grid

LuckyPort•100
@LuckyPort
A solution to the Single price grid component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


im not sure about this method i use rn , any suggestion will be very very appreciated

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Riley•260
    @rileydevdzn
    Posted about 2 years ago

    Hi! Congrats on completing the single price grid component!

    Here's a couple of suggestions:

    • It looks like you're assigning some headings (h1, h2, etc.) based on visual appearance. Headings (<h1>-<h6>) are section headings; semantically, they act as indicators that "hey here's a new section of content!" Join Our Community is perfect as the h1 (nicely done!) and both Monthly Subscription and Why Us are great as lower-level headings (like an h2 or h3), as they represent new sections of content inside the card.
    • You don't need to visually hide the h1 or repeat its content with an h2, just use the h1.
    • The price ($29) doesn't introduce a new section of content, so it would be better as a <p> element. You can use CSS to make the font-size of this element bigger and bolder, instead of using an h2 element.

    Good job using CSS Grid and global variables in your build! My suggestions were for semantic HTML, is there a particular area you were not sure of? Like how you structured or styled a specific element?

    Hope this helps and happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub