Single price grid component using grid

Solution retrospective
im not sure about this method i use rn , any suggestion will be very very appreciated
Please log in to post a comment
Log in with GitHubCommunity feedback
- @rileydevdzn
Hi! Congrats on completing the single price grid component!
Here's a couple of suggestions:
- It looks like you're assigning some headings (h1, h2, etc.) based on visual appearance. Headings (
<h1>-<h6>
) are section headings; semantically, they act as indicators that "hey here's a new section of content!" Join Our Community is perfect as the h1 (nicely done!) and both Monthly Subscription and Why Us are great as lower-level headings (like an h2 or h3), as they represent new sections of content inside the card. - You don't need to visually hide the h1 or repeat its content with an h2, just use the h1.
- The price ($29) doesn't introduce a new section of content, so it would be better as a
<p>
element. You can use CSS to make the font-size of this element bigger and bolder, instead of using an h2 element.
Good job using CSS Grid and global variables in your build! My suggestions were for semantic HTML, is there a particular area you were not sure of? Like how you structured or styled a specific element?
Hope this helps and happy coding!
Marked as helpful - It looks like you're assigning some headings (h1, h2, etc.) based on visual appearance. Headings (
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord