Our reporter did not find any issues in this project! π
Design comparison
Reports
Abhijit Moryeβs questions for the community
Hi All,
I have completed this challenge which requires basic HTML and CSS. feedbacks are most welcome.
Community feedback
Hey Abhijit, nice job coding this. Using class names for almost all your CSS selectors is really good and nice job using relative units. I would suggest giving the entire price grid component a width and then centering it within the page. It looks too wide as it is on large screen sizes.
2
@abhijitmorye
Posted
@En-Jen Yes sure.. Thanks for your suggestion
0
@rfilenko
Posted
Hey, put all our elements inside one container, give it a max-width, this way it will be easier to position it. Also be consistent with margins between elements, so use just margin-bottom, for example, for vertical rhythm. Initially set box-sizing:border-width - will help with sizing all your elements.
Keep practicing, Roman
1
@abhijitmorye
Posted
@rfilenko Thanks for the suggestion..i will keep these in mind while coding.
0
Please log in to post a comment
Log in with GitHubJoin our Slack community
Join over 180,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!