@isprutfromua
Posted
Hi there. You did a good job 😎
keep improving your programming skills🛠️
your solution looks great, however, if you want to improve it, you can follow these recommendation:
**HTML**
✅ Use HTML5 semantic elements. Make sure correct use of the HTML5 semantic elements like: header, footer, main, nav, article, section. It’s will help you to write more structured piece of code.
✅ Avoid complex wrapping. For better performance please tried to avoid unnecessary wrapping. It will create unnecessary node in your HTML tree and reduce performance too.
✅ Follow a consistent HTML format. It is important to remain consistent in your HTML style. You can use prettier to help you with that but the goal is to always follow a consistent way you code your markup.
BAD practice:
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Karla&display=swap" rel="stylesheet">
<title>Frontend Mentor | Single Price Grid Component</title>
===================================================
<div class="right-sec">
<h3>Why Us</h3>
<p>Tutorials by industry experts <br>
Peer & expert code review <br>
Coding exercises <br>
Access to our GitHub repos <br>
Community forum <br>
Flashcard decks <br>
New videos every week</p>
</div>
</div>
</main>
**CSS**
✅ Use a CSS reset . By default, browsers don’t apply the same default styling to HTML elements, a CSS reset will ensure that all element have no particular style. For example: css-reset
✅ Write consistent CSS. At the beginning part of the project you can set some rules for maintain throughout to your entire stylesheet. If you follow the convention or BEM, you’ll be able to write CSS without being afraid of side effects.
body{
background-color: hsl(204, 43%, 93%);
font-family: 'Karla', sans-serif;
}
h1{
color: hsl(179, 62%, 43%);
}
h2{
color: hsl(71, 73%, 54%);
}
================================
.top-sec{
border-top-left-radius: 0.5rem;
border-top-right-radius: 0.5rem;
background-color: white;
height: auto;
width: fit-content;
padding: 1.5rem 5rem 1.7rem 3.35rem;
}
✅ Use mobile first development approach. A mobile-first approach to styling means that styles are applied first to mobile devices.
✅ Use CSS Variables . Making the code flexible is equally important so that refactoring won’t be a problem for you. One of the best ways to achieve this is variables.
I hope my feedback will be helpful. You can mark it as useful if so 👍 it is not difficult for you, but I understand that my efforts have been appreciated
Good luck and fun coding 🤝⌨️
@AmritPal91
Posted
@isprutfromua Thanks you so much for your feedback. I will take care of your recommendations. As I am beginner in the field of programming Can I ask for your help if I stuck somewhere or regarding the clarity of any concept?
@isprutfromua
Posted
@AmritPal91 I'm glad that my comment was helpful to you. I will be very pleased if you mark my comment as useful.
Contact me if you have any questions
Cheers