Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Single price grid component using HTML and SASS.

@Godfredgameli

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I will highly cherish some feedback on my single grid component challenge. Let me know your thoughts. Thank you.

Community feedback

Szymon Rojek 4,540

@SzymonRojek

Posted

Hi Godfred,

Great, another challenge! Well done :D

I have checked your HTML by the inspector in my browser, a few tips for you:

  • instead of div class="main-wrapper" we can use the main tag and instead of content-wrapper we can add the section tag;
  • I know this is only a component but also you can see it as a single page component so you could do h1 with to spans inside of: main-heading(Join our community) and sub-heading(30-day, hassle-free money back guarantee) but also a sentence Join our community can become h1, underneath will h2, and last - paragraph. Also, you can leave it like this but add the h1 tag with the class sr-only hidden for Screen Readers;
<div>
     <span class="price"> $29</span> <span class="rate">per month</span>  
</div>

in this code above, instead of divs you can use paragraph (it will be semantically better);

  • what do you think to use a button instead of a link? Also, submit => we are not submitting here at the moment we just want to go to a different part of a page. **Very well that you didn't set outline to none.

Design:

  • give more space between price and per month;
  • set max-width to the container;
  • first box: you have got there two sentences (grey color) => on tablet / desktop size they should be separate (start from new line each);

That's from me. Ps. Don't forget to upvote any comments on here that you find helpful.

Greetings :D

1

@Godfredgameli

Posted

Thank you for the feedback. I have updated the work now.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord