Submitted over 1 year ago

Single Price Grid Component Zach Class with adjustments.

Andres• 70

@XJuanRocksX

Preview site View code

This is a solution for...

Single price grid component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Community feedback

Lucas 👾• 104,560

@correlucas

Posted over 1 year ago

👾Hello @XJuanRocksX, Congratulations on completing this challenge!

Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

1.Add the background color --> background-color: #E7EFF6

2.Add the website favicon inserting the svg image inside the <head>. <link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">

3.I saw that for some properties you’ve used rem and for others px. In this case, it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

✌️ I hope this helps you and happy coding!

Marked as helpful

Kawsar Ahmed Fahad• 2,680

@faha1999

Posted over 1 year ago

Hello, Andres Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

You might want to use semantic tags like the <main> to wrap your code, instead of div. like

<main id="card">
</main>

This would help improve accessibility.

add favicon <link rel="icon" type="image/png" sizes="32x32" href="./images/favicon-32x32.png">
add the below styles to the body. It will center everything

body {
    justify-content: center;
    align-items: center;
    display: flex;
    min-height: 100vh;
    flex-direction: column;
    /* padding: 20px; */
}

remove margin: auto; in the #card
use modern CSS reset https://piccalil.li/blog/a-modern-css-reset/
Instead of using px, use relative units like rem or em to get better performance when the information on your page needs to be resized for multiple screens and devices. REM and EM apply to all sizes, not just font-size. You can code your entire page in px and then, at the very end, use the VsCode plugin px to rem to perform the automatic conversion px to rem

I hope it will work. Happy coding.

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord