Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

single-price-grid-component-master

@nath3010

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi guys! This is my first project using HTML and CSS. Can you give me some feedback?

Community feedback

@abhijitmorye

Posted

Hi Natasha, It's good job.just one point, you can make this page responsive using media queries. you can refer below link to learn about media queries.

https://www.youtube.com/watch?v=srvUrASNj0s&list=PLVca7tt7ZPRpVAe2DqfcbRQ1q3qvyg57_&index=14&t=14365s

2

@nath3010

Posted

thanks! i woll see the video!

0

@Dorian30

Posted

Hi Natasha. I just saw your solution and also answer to you on slack. Really good job for a first project. Keep it going!

Regarding the feedback, I would tell you to use more semantics tags. Like for example: The top part could be a header

<header class="header">
  <h1>Join our community</h1>
  <h2>30-day, hassle-free money back guarantee</h2>
  <p>
      Gain access to our full library of tutorials along with expert code reviews. 
      Perfect for any developers who are serious about honing their skills.
  </p>
</header>

Then, your bottom content could be wrapped with section tag instead and then use an article tag (the article tag is used for whatever part of content that makes sense by itself regardless of page context)

Also, you can have one h1 tag for every article or section you declare. This helps with semantics and SEO.

<section class="bottom-content">
        <article class="price">
             <h1>Monthly Subscription</h1> 
              <p class="content-one"><span>$29</span> per month</p>
              <p>Full access for less than $1 a day</p>
              <a class="btn">Sign Up</a>
        </article>
        <article class="us">
          <h1>Why Us</h1>
          <p>  Tutorials by industry experts<br>
            Peer & expert code review<br>
            Coding exercises<br>
            Access to our GitHub repos<br>
            Community forum<br>
            Flashcard decks<br>
            New videos every week</p>
        </article>
</section>

Lastly I would advice to avoid using br tags. HTML is a markup and it is only for labeling things. If you want to position your elements in a certain always go for CSS instead.

Also, you can use 2 spaces of indentation instead of 4 (helps readability). About positioning I would suggest to use CSS Grid or flexbox instead of floating elements. It gives more control over your elements.

I hope this helps! Let me know if you have any more doubts.

Some reading I recommend:

https://medium.com/wolox/what-margin-padding-taught-me-after-50-projects-6878b53c903f

1

@nath3010

Posted

thanks for the help! instead of tags what i can use? is better to use a list?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord