Site using HTML AND CSS

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojek

  Posted over 4 years ago

  Hi Raj,

  Welcome here! Well done :D

  I have checked your HTML structure, a few tips for you:

  • instead of <div class="main_container"> you can add semantic tag main;
  • generally all three divs you can put into the section tag**;
  • using ID's just for styling it is not a good practice (you will need them with JS);
  • instead of the button you can also use the link => check this article from the CSS-tricks: A Complete Guide to Links and Buttons; also, great that you didn’t remove the outline! :D
  • in the third box it is good occasion to use unordered list and list item ul > li.

  Design:

  • first box: black text should be have a grey color ;
  • also there is a small detail (check the design folder) => on mobile two paragraphs in the first box are together as a text but later they are like two separate paragraphs;
  • on mobile: add margin top and bottom.

  That's from me.

  Greetings :D

  30
• 

  David Ouma•270

  @daudi13

  Posted over 4 years ago

  Hi, Raj. I've taken a look at your code and I found your project very responsive in both mobile and desktop. I just have a few suggestions.

  1.Make use of BEM naming convention. it is very easy to learn and use. Because it will make working on your CSS very easy and you're going to need it when you work with JS.

  2.Avoid using button for clickable buttons but instead use button:submit.

  Thank you for your submission and keep up the good work. Happy coding.

  13