Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social link profile

vv• 80

@dblvv

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Finally started with css variable.

Don't really know how to use button:hover and :focus.

All should have landmark now.

What challenges did you encounter, and how did you overcome them?

resetting styles again

difference of em and rem

What specific areas of your project would you like help with?

Sizing and scaling

Community feedback

Daniel 🛸• 35,480

@danielmrz-dev

Posted

Hello @dblvv!

Your solution looks great!

📌 Instead of using <button> as list items, it's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

Here's how you can refactor your code:

Before Refactoring

    <button>Github</button>
    <button>Frontend Mentor</button>
    <button>LinkedIn</button>
    ...

After Refactoring

<ul class="list-container">
    <li><a href="#">Github</a></li>
    <li><a href="#">Frontend Mentor</a></li>
    <li><a href="#">LinkedIn</a></li>
    ...
</ul>

By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

I hope you find this helpful!

Keep up the excellent work!

1

@cintiavic

Posted

Looks good to me! As regards to relative units, I suggest this article: https://refine.dev/blog/rem-vs-em/#what-is-css-rem Hope it helps!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord