Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Social Link Profile made with HTML/CSS

Dylan•290
@dquinn089
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I was more focused on have readable code this time around, making use of the different elements HTML has to offer to create landmarks that offer a much more appealing structure for the reader.

What challenges did you encounter, and how did you overcome them?

I'm still not really sure why, but I was having trouble with the font in the button elements. Even though I correctly integrated the link for the font that was given in the style-guide, and setting it to the font property in the body element; it didn't change the font for the buttons. I just had to explicitly set the button element font property to the same font.

What specific areas of your project would you like help with?

Not really sure specifically for this one, but I will take any tips on ways to streamline the process for building these HTML structures more efficiently, as well as design tips for CSS.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Alex•3,130
    @Alex-Archer-I
    Posted about 1 year ago

    Hi!

    Great work, congrats! It's very neat and close to design =)

    I can give you a couple suggestions about semantic. It's a list of links, so it's better to use ul tag here and put a inside li. Like this:

    <ul>
        <li><a href="#">It's a link here!</a></li>
        ...and more links here
    </ul>
    

    Than you doesn't need a button inside a - it's a tags with very different purposes =) Also it is recommended not to skip headers hierarchy - I mean after the h1 should follow h2 etc.

    Oh, and you can get rid of margin: auto for the main (good that you are use main tag, btw) since you already centered it with body tag.

    Hope that helps. Keep doing great stuff =)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub