Skip to content
Submitted about 1 year ago

Social Links

accessibility
Dan P.•270
@Danielfww
A solution to the Social links profile challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

That I didn't give up on this project, thanks @Pipendog for your help.

What challenges did you encounter, and how did you overcome them?

I added too many br's in my html, it was messing up my whole container. I rushed this project in the end, while I should have been making sure that I make less mistakes - I will try to focus more on reviewing my stuff before I ask other people for help.

What specific areas of your project would you like help with?

None but any advice or suggestions are much appreciated.

Code

Please log in to post a comment

Log in

Community feedback

  • P
    Daniel 🛸•44,810
    @danielmrz-dev

    Hello there!

    Congrats on completing the challenge! ✅

    Your project is looking fantastic!

    I'd like to suggest a way to make it even better:

    • Using margin isn't always the most effective method for centering an element.

    Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:

    📌 Apply this CSS to the body (avoid using position or margins in order to work correctly):

    body {
    min-height: 100vh;
    display: flex; 
    justify-content: center;
    align-items: center;
}

    I hope you find this helpful!

    Keep up the excellent work!

    Marked as helpful
  • Alex•3,130
    @Alex-Archer-I

    HI! Well done, your work quite similar to original design!

    I can recommend you to use one class name for the identical elements - like just .button in your case. It'll help to reduce your css code and make it more readability. Also you can reduce margin-left and margin-right to margin: 0 auto.

    Hope that helps. Keep doing =)

  • Erfan•310
    @ERFAN-REVENANT

    Hey Dan P.- great job on finishing this project. If I had to recommend anything here, I would suggest you would use the following to center your div to the middle of the page:

    body {

min-height: 100vh;
display: flex; 
justify-content: center;
align-items: center;
}

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord