Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Links Card

Rami Hegazyā€¢ 60

@Rami-Hegazy

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I think I did good, Let me know.

Community feedback

Alexā€¢ 360

@ByKyZo

Posted

Hi, good job!

Just a few points to consider:

  • Wrap your links in a list for semantics.
  • Add alt descriptions for images for accessibility.
  • Make your container responsive because on some devices (e.g., galaxy fold), the container extends beyond the screen. You can perhaps use max-width to address this.

Keep coding :)

Marked as helpful

0
Daniel šŸ›øā€¢ 38,730

@danielmrz-dev

Posted

Hello @Rami-Hegazy!

Your solution looks excelent!

I have just one suggestion:

šŸ“Œ In order to make your HTML code more semantic, use <h1> for the main title instead of <p>.

The tag <p> is meant for paragraphs. For titles, we have the HTML headings (the tags <h1> to <h6>).

Here's a quick guide on how to use them:

Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord