Social links profile

Community feedback

• 

  P

  Serhii Orlenko•415

  @grifano

  Posted about 1 year ago

  Hi Adal 👋 Congrats on completing this challenge, great job 👏

  Here are a few suggestions that help you improve your solution;

  • [HTML] You have a h1 tag which is great, however next you use h6 and this isn’t good practice as you jump through h2,h3,h4,h5;
  • [HTML] Use the main tag for the main content. In this challenge we don’t have much content, overall I recommend reading more about semantics to you;
  • [CSS] You use some useless properties like height for html and body;
  • [CSS] Instant of using selector div h1 {...} I recommend setting classes for each element that you would like to style, this makes your code more readable.
  • [CSS] Adding transitions for links makes hover look more attractive.

  These is a few suggestions, and it is always can be something to improve. You can get back to this challenge when after a while and check your self 🙂

  Great job, keep going, and remember that you are better of yourself each day 💪

  10

  Marked as helpful