Social links profile

Community feedback

• 

  tediko•6,700

  @tediko

  Posted over 1 year ago

  Hello @davidsonaguiar,

  Congrats on finishing another project! There is a few thing that you can change:

  • Your image isn't decorative. Provide alt attribute with description for the non-sighted users.
  • Why do you select both body and html elements in your CSS? There is no need to apply style rules to both of them, so stick only with body {} selector.
  • Block elements (like html , body , div , p ) have width 100% automatically so width is not required for body element, remove that property from your css rules.
  • Since you used justify-content and align-items properties in your body to align your flex items both horizontally and vertically there is no need to add margin: auto to your main element which is now your flex item. Don't Repeat Yourself.
  • Headings are signposts that guide readers through component. Therefore, they should indicate what a section or a paragraph is about. Keep your <h1> heading which is title of your component but change <h2> to <p> element.
  • You forgot to wrap your list items content within anchor tags <a> so they can point to external website.

  Good luck!

  01

  Marked as helpful
• 

  P

  Daniel 🛸•44,790

  @danielmrz-dev

  Posted over 1 year ago

  Fala @davidsonaguiar!

  Seu projeto ficou excelente!

  Tenho uma sugestão:

  • Como aqueles "botões" são links pra páginas externas, você pode encapsular o texto deles com a tag <a>. Faz sentido, já que a idéia é que quando forem clicados, o usuário seja direcionado para as respectiva página da rede social.

  Fora isso, está ótimo!

  Espero que ajude!

  01