Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social links profile

#accessibility#bem

@davidsonaguiar

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Tips?

Community feedback

P
tediko 6,580

@tediko

Posted

Hello @davidsonaguiar,

Congrats on finishing another project! There is a few thing that you can change:

  • Your image isn't decorative. Provide alt attribute with description for the non-sighted users.
  • Why do you select both body and html elements in your CSS? There is no need to apply style rules to both of them, so stick only with body {} selector.
  • Block elements (like html , body , div , p ) have width 100% automatically so width is not required for body element, remove that property from your css rules.
  • Since you used justify-content and align-items properties in your body to align your flex items both horizontally and vertically there is no need to add margin: auto to your main element which is now your flex item. Don't Repeat Yourself.
  • Headings are signposts that guide readers through component. Therefore, they should indicate what a section or a paragraph is about. Keep your <h1> heading which is title of your component but change <h2> to <p> element.
  • You forgot to wrap your list items content within anchor tags <a> so they can point to external website.

Good luck!

Marked as helpful

0

@davidsonaguiar

Posted

@tediko Dude, thank you very much for the tips, I'll make the changes

0
Daniel 🛸 37,330

@danielmrz-dev

Posted

Fala @davidsonaguiar!

Seu projeto ficou excelente!

Tenho uma sugestão:

  • Como aqueles "botões" são links pra páginas externas, você pode encapsular o texto deles com a tag <a>. Faz sentido, já que a idéia é que quando forem clicados, o usuário seja direcionado para as respectiva página da rede social.

Fora isso, está ótimo!

Espero que ajude!

0

@davidsonaguiar

Posted

@danielmrz-dev Pow cara, não tinha percebido, esquici. vlw.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord